Skip to content

fix: flag schema derive on schemars feature#966

Merged
DaleSeo merged 1 commit into
mainfrom
fix-schema-feature-flag
Jul 9, 2026
Merged

fix: flag schema derive on schemars feature#966
DaleSeo merged 1 commit into
mainfrom
fix-schema-feature-flag

Conversation

@jamadeo

@jamadeo jamadeo commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Most derive(schemars::JsonSchema)s are flagged on the schemars feature, except for one instance (EmptyObject) which was flagged on server. This seems like a mistake, and means that enabling only schemars misses this one type.

Also changes the server feature to include the schemars feature itself, not just the dep. This does increate the server API, but preserves compatibility and I think aligns with the intention.

Motivation and Context

Makes rmcp buildable with only the schemars feature

How Has This Been Tested?

cargo check -p rmcp --no-default-features --features server
cargo check -p rmcp --no-default-features --features schemars

Breaking Changes

No breaking changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@jamadeo jamadeo requested a review from a team as a code owner July 9, 2026 17:26
@github-actions github-actions Bot added T-dependencies Dependencies related changes T-config Configuration file changes T-core Core library changes labels Jul 9, 2026

@DaleSeo DaleSeo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, @jamadeo!

@DaleSeo DaleSeo merged commit 60d3e77 into main Jul 9, 2026
21 checks passed
@DaleSeo DaleSeo deleted the fix-schema-feature-flag branch July 9, 2026 23:51
@github-actions github-actions Bot mentioned this pull request Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-config Configuration file changes T-core Core library changes T-dependencies Dependencies related changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants